[repo] Address issues with dark mode (fixes #1384) #1402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses dark mode styling by introducing a custom background color variable.
- Adds a new CSS variable for the dark mode background color.
Comments suppressed due to low confidence (2)
src/css/custom.css:48
- [nitpick] Consider adding a comment above this line to explain the choice of
#1b1b1dand how it integrates with the overall dark theme palette.
--ifm-background-color: #1b1b1d;
src/css/custom.css:48
- It would be helpful to add a visual regression test or CSS snapshot test to verify that the background color is applied correctly in dark mode.
--ifm-background-color: #1b1b1d;
✅ Deploy Preview for moodledevdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
HuongNV13
approved these changes
Jul 15, 2025
Member
|
Thanks, Andrew! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.